On Sat, Apr 13, 2019 at 12:31:43PM +0000, Igor Russkikh wrote: > From: Yana Esina <yana.es...@aquantia.com> > > Ability to read the chip temperature from memory > via hwmon interface
> + /* Convert PHY temperature from 1/256 degree Celsius > + * to 1/1000 degree Celsius. > + */ > + *temp = temp_res * 1000 / 256; > + > + return 0; > +} Hi Igor, Yana Is this a single chip MAC/PHY, or is there a discrete PHY? If this is not a single chip solution, maybe this should be called get_phy_temp, so you can later add a get_mac_temp. Andrew