This patch series addresses 2 related issues: 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" warning due to type difference of SPEED_UNKNOWN constant (int) and argument to ethtool_validate_speed (__u32).
2. some drivers use u16 storage for SPEED_UNKNOWN constant, resulting in value truncation and thus failure to test against SPEED_UNKNOWN correctly. This revised series addresses several feedback comments: - split up the patch in to series - do not unnecessarily change drivers that use "int" storage for speed values Michael Zhivich (3): ethtool: avoid signed-unsigned comparison in ethtool_validate_speed() broadcom: tg3: fix use of SPEED_UNKNOWN ethtool constant qlogic: qlcnic: fix use of SPEED_UNKNOWN ethtool constant drivers/net/ethernet/broadcom/tg3.c | 8 ++++---- drivers/net/ethernet/broadcom/tg3.h | 4 ++-- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 2 +- include/uapi/linux/ethtool.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) -- 2.7.4
