On 03.04.2019 22:46, Andrew Lunn wrote:
>> @@ -2218,9 +2223,9 @@ int phy_driver_register(struct phy_driver *new_driver,
>> struct module *owner)
>> /* Either the features are hard coded, or dynamically
>> * determine. It cannot be both or neither
>> */
>
> Hi Heiner
>
> The comment needs updating to match the code.
>
Indeed, I have to fix this.
>> - if (WARN_ON((!new_driver->features && !new_driver->get_features) ||
>> - (new_driver->features && new_driver->get_features))) {
>> - pr_err("%s: Driver features are missing\n", new_driver->name);
>> + if (WARN_ON(new_driver->features && new_driver->get_features)) {
>> + pr_err("%s: features and get_features must not both be set\n",
>> + new_driver->name);
>> return -EINVAL;
>
> Andrew
>
