Re: [PATCH net-next 1/2] net: phy: allow a PHY driver to define neither features nor get_features

[Andrew Lunn]

> @@ -2218,9 +2223,9 @@ int phy_driver_register(struct phy_driver *new_driver, 
> struct module *owner)
>       /* Either the features are hard coded, or dynamically
>        * determine. It cannot be both or neither
>        */

Hi Heiner

The comment needs updating to match the code.

> -     if (WARN_ON((!new_driver->features && !new_driver->get_features) ||
> -                 (new_driver->features && new_driver->get_features))) {
> -             pr_err("%s: Driver features are missing\n", new_driver->name);
> +     if (WARN_ON(new_driver->features && new_driver->get_features)) {
> +             pr_err("%s: features and get_features must not both be set\n",
> +                    new_driver->name);
>               return -EINVAL;

        Andrew