On Fri, 15 Mar 2019 18:06:45 +0800 Zhiqiang Liu <[email protected]> wrote:
> From: "Suanming.Mou" <[email protected]> > > With ad6c9986bcb6, GRO cells will be destroyed in vxlan_uninit. Thanks for cleaning this up. I think it would be nice if you could actually explain in the commit message why this makes the call in vxlan_destroy_tunnels() redundant. > Fixes: ad6c9986bcb6 ("vxlan: Fix GRO cells race condition between receive and > link delete") I'm not sure a Fixes: tag is appropriate here (and also if this shouldn't be targeted for net-next) -- in the end, gro_cells_destroy() there would just return: if (!gcells->cells) return; > Signed-off-by: Suanming.Mou <[email protected]> Either way, Reviewed-by: Stefano Brivio <[email protected]> -- Stefano
