>  static int ksz9477_phy_read16(struct dsa_switch *ds, int addr, int reg)
> @@ -353,7 +363,7 @@ static int ksz9477_phy_read16(struct dsa_switch *ds, int 
> addr, int reg)
>                       val = 0x796d;
>                       break;
>               case MII_PHYSID1:
> -                     val = 0x0022;
> +                     val = KSZ9477_ID_HI;
>                       break;
>               case MII_PHYSID2:
>                       val = 0x1631;

Hi Tristram

This seems like an unrelated change, so should be in a separate
patch. And if you change PHYID1, it would also make sense to change
PHYID2 to a #define.


Please split the tagging changes into a patch of there own.

       Andrew

Reply via email to