>Subject: Re: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs
>
[..]
>> > + ret = irdma_alloc_rsrc(iwdev->rf,
>> > + iwdev->rf->allocated_mrs, iwdev->rf->max_mr,
>> > + &stag_index, &next_stag_index);
>> > + if (!ret) {
>> > + stag = stag_index << IRDMA_CQPSQ_STAG_IDX_S;
>> > + stag |= driver_key;
>> > + stag += (u32)consumer_key;
>> > + irdma_add_devusecount(iwdev);
>> > + }
>>
>> This is confusing IMHO, better to test for 'if (ret)' and keep the
>> main flow unindented.
>
>Yes please follow the standard 'success oriented flow'
>
OK.
