On Sat, Feb 23, 2019 at 6:31 PM David Miller <da...@davemloft.net> wrote: > > From: Cong Wang <xiyou.wangc...@gmail.com> > Date: Sat, 23 Feb 2019 17:11:08 -0800 > > > On Sat, Feb 23, 2019 at 1:21 PM David Miller <da...@davemloft.net> wrote: > >> > >> You are forcing everyone who wants to use this to add a curstom local > >> source code change into their build. > > > > What's wrong with this? People carry custom changes in anyway, > > do we really need to care about all the downstream changes? > > No way am I allowing this, sorry. > > Either it's something in the tree that people can use or it's > a crap hack. > > When we see stuff like this in a driver we ask the driver author to > remove it.
Just to clarify, I have been suggesting to completely remove this unused macro, never suggest to just undefine it in-tree. There is no reason to keep it in-tree, whether defined or undefined, just for downstream users. Thanks.
