On 28.01.2019 21:59, Marc Haber wrote: > On Mon, Jan 28, 2019 at 08:02:47PM +0100, Heiner Kallweit wrote: >> One more test .. Can you provide the output of the following under 4.18 and >> under 4.19? >> It may not apply cleanly, but you get the idea. The message is written when >> suspending. > > I booted, suspeneded, sent a magic packet that got ignored. I then woke > the box up with the any key, went through the ethtool motions, suspended > again, sent a magic paket that the machine acted on and woke up > > Log says: > 1 [1/4994]mh@fan:~ $ grep 'may wakeup' /var/log/syslog/syslog > Jan 28 21:51:44 fan kernel: [ 77.571211] may wakeup? 0 > Jan 28 21:54:11 fan kernel: [ 183.994131] may wakeup? 1 > [2/4995]mh@fan:~ $ > > Greetings > Marc >
Thanks, this makes clearer what's going on. This change to r8169 bde135a672bf ("r8169: only enable PCI wakeups when WOL is active") removed marking the device as wakeup-enabled to work around an issue on certain notebooks (see commit message for details). ethtool doesn't care about the current settings and sets the new ones (wakeup-enabling the device). systemd however checks the current settings and writes new ones only if there's a change. Therefore in your case systemd does nothing and device doesn't get wakeup-enabled. Not totally clear to me is why it works under 4.18. And I wonder why the following didn't work for you, you said it makes no difference. Could you try again the following in addition to the latest debug output statement? drivers/net/ethernet/realtek/r8169.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3e650bd9e..bd26d3f2e 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -7442,6 +7442,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) } tp->saved_wolopts = __rtl8169_get_wol(tp); + device_set_wakeup_enable(&pdev->dev, tp->saved_wolopts); mutex_init(&tp->wk.mutex); INIT_WORK(&tp->wk.work, rtl_task); --