On Sun, 13 Jan 2019 09:08:56 -0700, David Ahern wrote:
> On 1/12/19 2:07 PM, Joe Perches wrote:
> > On Sat, 2019-01-12 at 12:45 -0800, Jakub Kicinski wrote:
> >> "IPv6: " prefix is already added by pr_fmt, no need to include
> >> it again in the pr_warn() format.
> > []
> >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > []
> >> @@ -4256,7 +4256,7 @@ static void ip6_print_replace_route_err(struct
> >> list_head *rt6_nh_list)
> >> struct rt6_nh *nh;
> >>
> >> list_for_each_entry(nh, rt6_nh_list, next) {
> >> - pr_warn("IPV6: multipath route replace failed (check
> >> consistency of installed routes): %pI6c nexthop %pI6c ifi %d\n",
> >> + pr_warn("multipath route replace failed (check consistency of
> >> installed routes): %pI6c nexthop %pI6c ifi %d\n",
> >
> > Thanks.
> >
> > Just asking, couldn't this emit a rather long list?
> > Perhaps it should be ratelimited?
> >
> >
>
> That should be converted to an extack message now.
I assumed the information from the format is of importance.
Let me respin then.
