Hi Florian,
Thanks for a quick review,
On 08-01-19, 09:59, Florian Fainelli wrote:
> On 1/8/19 8:29 AM, Vinod Koul wrote:
> > + if (phydev->interface == PHY_INTERFACE_MODE_RGMII) {
> > + ret = at803x_disable_rx_delay(phydev);
> > + if (ret < 0)
> > + return ret;
> > + ret = at803x_disable_tx_delay(phydev);
> > + if (ret < 0)
> > + return ret;
> > + }
>
> This looks right in that PHY_INTERFACE_MODE_RGMII from the perspective
> of the PHY means no TX/RX delays, but you would also have to take care
> of PHY_INTERFACE_MODE_RGMII_TXID and disable the RX delay in that case,
> and PHY_INTERFACE_MODE_RGMII_RXID and disabled the TX delay in that case.
Okay and I guess same about the PHY_INTERFACE_MODE_RGMII_ID. Right now
driver enables delay for PHY_INTERFACE_MODE_RGMII_ID and
PHY_INTERFACE_MODE_RGMII_TXID, PHY_INTERFACE_MODE_RGMII_RXID so I would
remove that as well..
Thanks
--
~Vinod
