Hi Andrew,
For moment, I've only tested with PHY RGMII, RMII, MII, GMII, I do not have
other kind of PHY interface.
Normally there is no impact in my glue, the value of syscfg register will be
the same for RGMII/ID/TXID/RXID.
Do you think that I should add these interfaces in my case ?
case PHY_INTERFACE_MODE_RGMII:
> + case PHY_INTERFACE_MODE_RGMII_ID:
> + case PHY_INTERFACE_MODE_RGMII_RXID:
> + case PHY_INTERFACE_MODE_RGMII_TXID:
val = SYSCFG_PMCR_ETH_SEL_RGMII;
if (dwmac->int_phyclk)
val |= SYSCFG_PMCR_ETH_CLK_SEL;
pr_debug("SYSCFG init : PHY_INTERFACE_MODE_RGMII\n");
break;
Christophe.
-----Original Message-----
From: Andrew Lunn [mailto:and...@lunn.ch]
Sent: mardi 24 avril 2018 17:40
To: Christophe ROULLIER <christophe.roull...@st.com>
Cc: mark.rutl...@arm.com; mcoquelin.st...@gmail.com; Alexandre TORGUE
<alexandre.tor...@st.com>; Peppe CAVALLARO <peppe.cavall...@st.com>;
devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
netdev@vger.kernel.org
Subject: Re: [PATCH 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c.
On Tue, Apr 24, 2018 at 05:01:53PM +0200, Christophe Roullier wrote:
> + case PHY_INTERFACE_MODE_RGMII:
> + val = SYSCFG_PMCR_ETH_SEL_RGMII;
> + if (dwmac->int_phyclk)
> + val |= SYSCFG_PMCR_ETH_CLK_SEL;
> + pr_debug("SYSCFG init : PHY_INTERFACE_MODE_RGMII\n");
> + break;
Hi Christophe
What about PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and
PHY_INTERFACE_MODE_RGMII_TXID.
Andrew
