Hi Rob,

On 04/25/2018 05:09 PM, Rob Herring wrote:
On Tue, Apr 24, 2018 at 10:01 AM, Christophe Roullier
<christophe.roull...@st.com> wrote:
Add ethernet pins on stm32mp157c.

Signed-off-by: Christophe Roullier <christophe.roull...@st.com>
---
  arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 46 +++++++++++++++++++++++++++++++
  1 file changed, 46 insertions(+)

diff --git a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi
index 6f044100..86720a5 100644
--- a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi
@@ -158,6 +158,52 @@
                                         bias-disable;
                                 };
                         };
+
+                       ethernet0_rgmii_pins_a: rgmii@0 {

A unit-address without 'reg' property is not valid, so drop the '@0'.

Thanks for the highlights. We could replace rgmii@0 by rgmii-0.
If no objections, I will send a series to update all STM32 device tree files (MCUs legacy). I will take care about it for future STM32 DT review.

Thanks
Alex

Please build your dtb with W=1 or W=12 which will tell you this and
other errors.


Rob

Reply via email to