On 04/17/2018 01:05 PM, Wolfram Sang wrote:
>> @@ -2302,6 +2305,7 @@ static int __maybe_unused ravb_resume(struct device
>> *dev)
>> {
>> struct net_device *ndev = dev_get_drvdata(dev);
>> struct ravb_private *priv = netdev_priv(ndev);
>> + struct platform_device *pdev = priv->pdev;
Could infer 'pdev' from 'dev' (avoiding the dereference)...
> Minor nit: I'd save this line...
>
>> + if (priv->chip_id != RCAR_GEN2)
>> + ravb_ptp_init(ndev, pdev);
>
> ... and use ravb_ptp_init(ndev, priv->pdev); here.
Agreed, no dire need for the new variable used only once.
MBR, Sergei
