On Tue, 27 Mar 2018 10:18:24 -0400 (EDT) Mathieu Desnoyers <mathieu.desnoy...@efficios.com> wrote:
> ----- On Mar 27, 2018, at 10:07 AM, rostedt rost...@goodmis.org wrote: > > > On Mon, 26 Mar 2018 19:47:02 -0700 > > Alexei Starovoitov <a...@fb.com> wrote: > > > >> From: Alexei Starovoitov <a...@kernel.org> > >> > >> introduce kernel_tracepoint_find_by_name() helper to let bpf core > >> find tracepoint by name and later attach bpf probe to a tracepoint > >> > >> Signed-off-by: Alexei Starovoitov <a...@kernel.org> > > > > Reviewed-by: Steven Rostedt (VMware) <rost...@goodmis.org> > > Steven showed preference for tracepoint_kernel_find_by_name() at some > point (starting with a tracepoint_ prefix). I'm find with either of > the names. Yeah, I do prefer tracepoint_kernel_find_by_name() to stay consistent with the other tracepoint functions. But we have "for_each_kernel_tracepoint()" and not "for_each_tracepoint_kernel()", thus we need to pick being consistent with one or the other. One answer is to use tracpoint_kernel_find_by_name() and rename the for_each to for_each_tracpoint_kernel(). -- Steve > > Reviewed-by: Mathieu Desnoyers <mathieu.desnoy...@efficios.com> > > Thanks, > > Mathieu > > > > > Thanks for doing this Alexei! > > > > One nit below.
