On 3/24/18 8:31 AM, Ido Schimmel wrote:
> On Sun, Mar 18, 2018 at 08:36:20PM -0700, David Ahern wrote:
>> @@ -405,18 +383,9 @@ static void ip6_dst_destroy(struct dst_entry *dst)
>> rt->rt6i_idev = NULL;
>> in6_dev_put(idev);
>> }
>> - bucket = rcu_dereference_protected(rt->rt6i_exception_bucket, 1);
>> - if (bucket) {
>> - rt->rt6i_exception_bucket = NULL;
>> - kfree(bucket);
>> - }
>> -
>> - m = rt->fib6_metrics;
>> - if (m != &dst_default_metrics && refcount_dec_and_test(&m->refcnt))
>> - kfree(m);
>
> You remove this...
>
>>
>> rt->from = NULL;
>> - dst_release(&from->dst);
>> + fib6_info_release(from);
>
> Yet fib6_info_release() doesn't take care of it (unlike the IPv4
> equivalent), which means you're leaking the metrics.
>
>> }
ok, I'll take a look. I thought I verified both paths (fib6_info and
dst) were freeing the metrics.
