> On Thu, Feb 22, 2018 at 10:45:34PM +0100, Andrew Lunn wrote: > > > Also I'm allocating interrupt resources on interface up, and freeing > > > resources on interface down. So if there is an up, down, up sequence > > > then the driver will allocate resources twice. In order for devm to > > > work properly, should I move all resource allocation into the probe > function? > > > > Hi Bryan > > > > It is better to fail early if the resource is not available, so yes, i > > would register the interrupt handler in probe. > > And we maintainers don't always agree with each other :-) > > Doing irq handling in open/close without devm_ is also O.K. > > Andrew
Thanks Andrew, and Florian, Moving irq allocation and free, to probe and remove, will require a bit of refactoring and possibly introduce new issues. For now I will keep IRQ handling in open/close without devm_. Other resource allocations are already in probe/remove so I will apply your suggestions in the next patch revision. Thanks, Bryan
