On Thu, Feb 22, 2018 at 10:45:34PM +0100, Andrew Lunn wrote:
> > Also I'm allocating interrupt resources on interface up, and freeing
> > resources
> > on interface down. So if there is an up, down, up sequence then the driver
> > will allocate resources twice. In order for devm to work properly, should I
> > move all resource allocation into the probe function?
>
> Hi Bryan
>
> It is better to fail early if the resource is not available, so yes, i
> would register the interrupt handler in probe.
And we maintainers don't always agree with each other :-)
Doing irq handling in open/close without devm_ is also O.K.
Andrew
