On Mon, 2018-01-22 at 12:27 -0500, tedheadster wrote: > On Mon, Sep 18, 2017 at 11:57 PM, David Miller <da...@davemloft.net> wrote: > > From: Eric Dumazet <eric.duma...@gmail.com> > > Date: Mon, 18 Sep 2017 13:03:43 -0700 > > > > > From: Eric Dumazet <eduma...@google.com> > > > > > > It seems we have to be more careful in napi_complete_done() > > > use. This patch is not a revert, as it seems we can > > > avoid bug that Ville reported by moving the napi_complete_done() > > > test in the spinlock section. > > > > > > Many thanks to Ville for detective work and all tests. > > > > > > Fixes: 617f01211baf ("8139too: use napi_complete_done()") > > > Reported-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > Tested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > > Applied and queued up for -stable. > > Eric, > sorry to bring up this old thread, but I had a question. Do we have > to surround most usage of napi_complete_done() with a spinlock, or was > this problem restricted to just the 8139too driver?
I am not aware of any other NIC driver having a problem there.