On Mon, Sep 18, 2017 at 11:57 PM, David Miller <[email protected]> wrote: > From: Eric Dumazet <[email protected]> > Date: Mon, 18 Sep 2017 13:03:43 -0700 > >> From: Eric Dumazet <[email protected]> >> >> It seems we have to be more careful in napi_complete_done() >> use. This patch is not a revert, as it seems we can >> avoid bug that Ville reported by moving the napi_complete_done() >> test in the spinlock section. >> >> Many thanks to Ville for detective work and all tests. >> >> Fixes: 617f01211baf ("8139too: use napi_complete_done()") >> Reported-by: Ville Syrjälä <[email protected]> >> Tested-by: Ville Syrjälä <[email protected]> > > Applied and queued up for -stable.
Eric, sorry to bring up this old thread, but I had a question. Do we have to surround most usage of napi_complete_done() with a spinlock, or was this problem restricted to just the 8139too driver? - Matthew Whitehead
