> -----Original Message-----
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, January 10, 2018 12:01 AM
> To: Chris Mi <chr...@mellanox.com>
> Cc: netdev@vger.kernel.org; gerlitz...@gmail.com; dsah...@gmail.com;
> marcelo.leit...@gmail.com; p...@nwl.cc
> Subject: Re: [patch iproute2 v7 2/2] tc: Add batchsize feature for filter and
> actions
>
> On Tue, 9 Jan 2018 15:59:08 +0900
> Chris Mi <chr...@mellanox.com> wrote:
>
> > +static bool batchsize_enabled(int argc, char *argv[]) {
> > + if (argc < 2)
> > + return false;
> > + if ((strcmp(argv[0], "filter") && strcmp(argv[0], "action"))
> > + || (strcmp(argv[1], "add") && strcmp(argv[1], "delete")
> > + && strcmp(argv[1], "change") && strcmp(argv[1], "replace")))
> > + return false;
> > +
> > + return true;
> > +}
>
> Maybe this should be a table, also the action can be abbreviated as in:
> tc qd a dev eth0 ...
Thanks for your notification. I've changed strcmp to matches.
Since the list is not very big, I didn't change it to use table in this
patchset.
>
> Actually, I have been wondering if all of IP commmand parsing needs to be
> more table driven.
