On Tue, 9 Jan 2018 15:59:08 +0900 Chris Mi <chr...@mellanox.com> wrote:
> +static bool batchsize_enabled(int argc, char *argv[]) > +{ > + if (argc < 2) > + return false; > + if ((strcmp(argv[0], "filter") && strcmp(argv[0], "action")) > + || (strcmp(argv[1], "add") && strcmp(argv[1], "delete") > + && strcmp(argv[1], "change") && strcmp(argv[1], "replace"))) > + return false; > + > + return true; > +} Maybe this should be a table, also the action can be abbreviated as in: tc qd a dev eth0 ... Actually, I have been wondering if all of IP commmand parsing needs to be more table driven.