From: Alexander Duyck <alexander.h.du...@intel.com>

If you enabled and disabled promiscuous mode on a VF you could easily put
it into a state where it would start firing interrupts on all queues at a
rate of 50+ interrupts per second even though there was no traffic present.
The issue seems to have been a stray admin queue feature flag set that was
leaving us in a high polling rate for the adminq task.

Signed-off-by: Alexander Duyck <alexander.h.du...@intel.com>
Tested-by: Andrew Bowers <andrewx.bow...@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
---
 drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c 
b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
index 2719a057b211..feb95b62a077 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
@@ -739,8 +739,10 @@ void i40evf_set_promiscuous(struct i40evf_adapter 
*adapter, int flags)
        }
 
        if (!flags) {
-               adapter->flags &= ~I40EVF_FLAG_PROMISC_ON;
-               adapter->aq_required &= ~I40EVF_FLAG_AQ_RELEASE_PROMISC;
+               adapter->flags &= ~(I40EVF_FLAG_PROMISC_ON |
+                                   I40EVF_FLAG_ALLMULTI_ON);
+               adapter->aq_required &= ~(I40EVF_FLAG_AQ_RELEASE_PROMISC |
+                                         I40EVF_FLAG_AQ_RELEASE_ALLMULTI);
                dev_info(&adapter->pdev->dev, "Leaving promiscuous mode\n");
        }
 
-- 
2.15.1

Reply via email to