Re: [for-next 07/11] net/mlx5: E-Switch, Create generic header struct to be used by representors

[David Miller]

From: Saeed Mahameed <sae...@mellanox.com>
Date: Tue, 19 Dec 2017 12:33:36 -0800

> +static int esw_offloads_load_reps(struct mlx5_eswitch *esw, int nvports)
> +{
> +     u8 rep_type = 0;
> +     int err;
> +
> +     while (rep_type < NUM_REP_TYPES) {
> +             err = esw_offloads_load_reps_type(esw, nvports,
> +                                               rep_type);
> +             if (err)
> +                     goto err_reps;
> +             rep_type++;
> +     }

Please, don't obfuscate what is a normal for() loop:

        for (rep_type = 0; rep_type < NUM_REP_TYPES; rep_type++)

Thanks.