On Wed, Nov 29, 2017 at 07:33:44PM +0000, Yan Markman wrote:
> Hi Russel
>
> On my board I have [Marvell 88E1510] phy working with STATUS-POLLING
> I see some inconsistencies -- first ifconfig-up is different from furthers,
> no "link is down" reports.
> Please refer the behavior example below.
> My patch is a "simple solution" -- always reset/clear Link-state-parameters
> before going UP.
> Possibly, more correct (but much more complicated) solution would be in the
> phy state machine and phylink resolve modification.
> I just found that
> On ifconfig-down, the phy-state-machine and phylink-resolve
> are stopped before executing before passing over full graceful down/reset
> state.
> The further ifconfig-up starts with old state parameters.
> Special cases not-tested but logic 2 test-cases are:
> remote side changes speed whilst link is Down or Disconnected. But local
> ifconfig-up starts with old speed.
Hi,
I think this is covered in my "phy" branch - but could probably do with
further testing, specifically this patch (which I've attached):
"phylink: ensure we take the link down when phylink_stop() is called"
This takes the link down on the MAC side synchronously when phylink_stop()
is called. However, I think your case might also benefit from this
patch - please test the patch referred to without this change, and let
me know if you need this change to solve your problem:
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 8f43f8779317..c90ad50204b0 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -798,6 +798,7 @@ void phylink_disconnect_phy(struct phylink *pl)
mutex_lock(&pl->state_mutex);
pl->netdev->phydev = NULL;
pl->phydev = NULL;
+ pl->phy_state.link = false;
mutex_unlock(&pl->state_mutex);
mutex_unlock(&phy->lock);
flush_work(&pl->resolve);
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
From: Russell King <rmk+ker...@armlinux.org.uk>
Subject: [PATCH] phylink: ensure we take the link down when phylink_stop() is
called
Ensure that we tell the MAC to take the link down when phylink_stop()
is called.
Reported-by: Florian Fainelli <f.faine...@gmail.com>
Tested-by: Florian Fainelli <f.faine...@gmail.com>
Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk>
---
drivers/net/phy/phylink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index fb7ae3f925f8..cb446b8acac2 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -880,6 +880,7 @@ void phylink_stop(struct phylink *pl)
sfp_upstream_stop(pl->sfp_bus);
set_bit(PHYLINK_DISABLE_STOPPED, &pl->phylink_disable_state);
+ queue_work(system_power_efficient_wq, &pl->resolve);
flush_work(&pl->resolve);
}
EXPORT_SYMBOL_GPL(phylink_stop);
--
2.7.4
