> + /* On _disconnect, the phy state machine and phylink resolve
> + * are stopped before executing full gracefull down/reset state.
> + * The further _connect starts with incorrect init state. Let's set
> + * init values here.
> + */
> + pl->phy_state.link = false;
> + pl->link_config.pause = MLO_PAUSE_AN;
> + pl->link_config.speed = SPEED_UNKNOWN;
> + pl->link_config.duplex = DUPLEX_UNKNOWN;
Hi Antoine
Looks sensible. My only comment would be, maybe it makes sense to
reduce the duplication by adding a little helper which is called here,
and in phylink_create()?
Andrew
