No need to test for it in fast-path, every dev in bpf_dtab_netdev
is guaranteed to be non-NULL, otherwise dev_map_update_elem() will
fail in the first place.

Signed-off-by: Daniel Borkmann <dan...@iogearbox.net>
---
 kernel/bpf/devmap.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index bfecabf..ecf9f99 100644
--- a/kernel/bpf/devmap.c
+++ b/kernel/bpf/devmap.c
@@ -226,12 +226,10 @@ void __dev_map_flush(struct bpf_map *map)
                if (unlikely(!dev))
                        continue;
 
-               netdev = dev->dev;
                __clear_bit(bit, bitmap);
-               if (unlikely(!netdev || !netdev->netdev_ops->ndo_xdp_flush))
-                       continue;
-
-               netdev->netdev_ops->ndo_xdp_flush(netdev);
+               netdev = dev->dev;
+               if (likely(netdev->netdev_ops->ndo_xdp_flush))
+                       netdev->netdev_ops->ndo_xdp_flush(netdev);
        }
 }
 
-- 
1.9.3

Reply via email to