On 17-07-31 02:38 AM, Jiri Pirko wrote:
Sun, Jul 30, 2017 at 09:59:10PM CEST, j...@mojatatu.com wrote:
Jiri,
This is getting exhausting, seriously.
I posted the code you are commenting one two days ago so i dont have to
repost.
And I commented on the "*u32 = *u32" thing. But you ignored it. Pardon
me for mentioning that again now :/
You commented on *u32 assignment from *void which i fixed. I
intentionally selected the different assignment names to reflect
meaning. Had you commented earlier - although I would have found
it disagreable - I would have fixed that too. Jiri, you need to be
more tolerant so progress can be made at times.
On D. Ahern: I dont think we are disagreeing anymore on the need to
generalize the check. He is saying it should be a helper and I already
had the validation data; either works. I dont see the gapping need
to remove the validation data.
DavidA? Your opinion.
With DavidA(reading his response) - the issue is one of taste.
Again either approach is fine. You can call helpers for every user
or make them invoked behind the scenes.
Again - like all your comments on code taste which I addressed, I
would have made that change if the comment had come in earlier. I got
exhausted. Imagine how a newbie corporate guy wouldve felt after this.
cheers,
jamal
