Sat, Jul 29, 2017 at 12:10:20AM CEST, j...@mojatatu.com wrote: >On 17-07-28 11:45 AM, Jiri Pirko wrote: >> Fri, Jul 28, 2017 at 05:08:10PM CEST, j...@mojatatu.com wrote: >> > On 17-07-28 10:52 AM, Jamal Hadi Salim wrote: >> > > On 17-07-28 10:12 AM, Jiri Pirko wrote: > > >> > /*disallow invalid selector */ >> > if ((bf->selector & *valid_flags_allowed) > *valid_flags_allowed) >> >> I don't get the ">".... >> Just (bf->selector & ~*valid_flags_allowed) should be enought, no? >> > >It may be enough - I will try it out tommorow. >I was worried about the selector having more bits than the allowed flags.
That is what the code I wrote above do. And I think that your code does not (if you don't assume that allowed flags are always starting from the least significant bit) > >cheers, >jamal
