On Tue, 2006-01-08 at 17:45 +1000, Herbert Xu wrote: > On Tue, Aug 01, 2006 at 12:36:14AM -0700, David Miller wrote: > > > > > > - tc_verd/tc_index/input_dev: when directing a packet from a device > > > > supporting GSO to a device not supporting GSO using tc actions, > > > > these fields may be set. > > > > > > This doesn't look right though. GSO should occur just before > > > hard_start_xmit (after all tc actions have taken place) so we > > > shouldn't have any more tc actions to perform. > > > > Hmmm, what about loopback? Yeah yeah, LOOPBACK_TSO is not defined :) > > but what I'm really referring to is that loopback preserves the > > traffic classifier bits of the skb. > > I don't know. Jamal, is there a scenario where these three attributes > are needed for loopback packets?
I didnt fully understand the scope of the discussion, but a little explanation may help answer the question: If the only spot where the GSO kicks in is at or after qdisc_is_running level, then the redirect will happen way before that point at qdisc->enqueue time. When we redirect or mirror, the packet is cloned and any metadata preserved at clone time needs to stay intact before dev_queue_xmit is hit for the destination device. And of course we have no checks for whether we are redirecting from a device that is GSO capable to one that is not (or vice-versa). If thats important, we could add a check. I am not sure if I answered the question ;-> cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
