On Tue, Aug 01, 2006 at 08:00:48AM -0400, Jamal Hadi Salim wrote:
> > >
> > > > > - tc_verd/tc_index/input_dev: when directing a packet from a device
> > > > > supporting GSO to a device not supporting GSO using tc actions,
> > > > > these fields may be set.
> > > >
> > > > This doesn't look right though. GSO should occur just before
> > > > hard_start_xmit (after all tc actions have taken place) so we
> > > > shouldn't have any more tc actions to perform.
> > >
> > > Hmmm, what about loopback? Yeah yeah, LOOPBACK_TSO is not defined :)
> > > but what I'm really referring to is that loopback preserves the
> > > traffic classifier bits of the skb.
> >
> > I don't know. Jamal, is there a scenario where these three attributes
> > are needed for loopback packets?
>
> I didnt fully understand the scope of the discussion, but a little
> explanation may help answer the question:
My question isn't really about GSO as such.
What I'd like to know is do we really need to preserve
tc_verd/tc_index/input_dev
for a packet crossing loopback's xmit function?
The reason I'm asking is because currently they're preserved as a matter
of course since loopback just shoves the same packet down the other end.
If we were to apply GSO to loopback (purely as a thought exercise since
loopback can handle large frames just fine without segmenting it :) would
we need to copy those attriutes?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
