Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

[Jamal Hadi Salim]

On 17-04-20 12:09 PM, Eric Dumazet wrote:

On Thu, 2017-04-20 at 09:06 -0400, Jamal Hadi Salim wrote:

        nest = nla_nest_start(skb, TCA_ACT_TAB);
        if (nest == NULL)
@@ -1113,6 +1136,8 @@ static int tc_dump_action(struct sk_buff *skb, struct 
netlink_callback *cb)
        if (ret > 0) {
                nla_nest_end(skb, nest);
                ret = skb->len;
+               memcpy(nla_data(count_attr), &cb->args[1], sizeof(u32));

This will not work on BigEndian 64bit hosts, since cb->args[1] is bigger
than 32bit.

Ok, thanks.
I will assign to a 32 bit var first then memcpy in the next iteration
(tomorrow).

cheers,
jamal