Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

[Eric Dumazet]

On Thu, 2017-04-20 at 09:06 -0400, Jamal Hadi Salim wrote:

>       nest = nla_nest_start(skb, TCA_ACT_TAB);
>       if (nest == NULL)
> @@ -1113,6 +1136,8 @@ static int tc_dump_action(struct sk_buff *skb, struct 
> netlink_callback *cb)
>       if (ret > 0) {
>               nla_nest_end(skb, nest);
>               ret = skb->len;
> +             memcpy(nla_data(count_attr), &cb->args[1], sizeof(u32));

This will not work on BigEndian 64bit hosts, since cb->args[1] is bigger
than 32bit.


> +             cb->args[1] = 0;
>       } else
>               nlmsg_trim(skb, b);
>