On Thu, 2017-04-06 at 10:08 -0400, Neal Cardwell wrote: > On Thu, Apr 6, 2017 at 10:05 AM, Gao Feng <gfree.w...@foxmail.com> wrote: > > If so, we should increase the TCP_MIB_OUTRSTS too when fail to alloc skb. > > When machine is overloaded and mem is exhausted, it may fail to alloc skb. > > Moving the increment of TCP_MIB_OUTRSTS to the top of > tcp_send_active_reset() sounds fine to me.
Yes. Keep in mind that whatever hard we try to send the packet, something might drop it later without TCP stack knowing it. So it is not really useful to test the immediate actions that are under our control.
