On Thu, Apr 6, 2017 at 9:35 AM, <gfree.w...@foxmail.com> wrote: > From: Gao Feng <f...@ikuai8.com> > > When fail to transmit RST, don't increase TCP_MIB_OUTRSTS in func > tcp_send_active_reset like the case that it only increases > LINUX_MIB_TCPABORTFAILED when fail to alloc skb. > > Signed-off-by: Gao Feng <f...@ikuai8.com> > ---
I would be concerned that this is a change in the semantics of TCP_MIB_OUTRSTS that might break user-space monitoring tools that rely on the current semantics. Counting attempted RSTs could be an important signal to monitor, and it could be quite bad if that signal is lost or hidden because the machine is so overloaded that the transmission of the RSTs fails. Also it would seem to muddy the semantics a bit, since both tcp_v4_send_reset() and tcp_v6_send_response() currently increment TCP_MIB_OUTRSTS without regard to whether the transmit actually succeeded or not. neal
