On Sun, Mar 12, 2017 at 04:07:55AM -0400, Zhu Yanjun wrote: > When rdma_accept fails, rdma_reject is called in it. As such, it is > not necessary to execute rdma_reject again. > > Cc: Joe Jin <joe....@oracle.com> > Cc: Junxiao Bi <junxiao...@oracle.com> > Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> > Signed-off-by: Zhu Yanjun <yanjun....@oracle.com> > --- > Change from v1 to v2: > Add the acker. > > net/rds/ib_cm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c > index ce3775a..eca3d5f 100644 > --- a/net/rds/ib_cm.c > +++ b/net/rds/ib_cm.c > @@ -677,8 +677,7 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, > event->param.conn.initiator_depth); > > /* rdma_accept() calls rdma_reject() internally if it fails */ > - err = rdma_accept(cm_id, &conn_param); > - if (err) > + if (rdma_accept(cm_id, &conn_param)) > rds_ib_conn_error(conn, "rdma_accept failed (%d)\n", err);
You omitted initialization of "err" variable which you print here ^^^^^. > > out: > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
signature.asc
Description: PGP signature
