The function ib_dealloc_fmr will never be called. As such, it should be removed.
Cc: Joe Jin <[email protected]> Cc: Junxiao Bi <[email protected]> Reviewed-by: Yuval Shaia <[email protected]> Reviewed-by: Johannes Thumshirn <[email protected]> Acked-by: Santosh Shilimkar <[email protected]> Signed-off-by: Zhu Yanjun <[email protected]> --- Change from v1 to v2: Add the reviewer and acker. Remove ibmr NULL test. net/rds/ib_fmr.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/rds/ib_fmr.c b/net/rds/ib_fmr.c index 4fe8f4f..249ae1c 100644 --- a/net/rds/ib_fmr.c +++ b/net/rds/ib_fmr.c @@ -78,12 +78,9 @@ struct rds_ib_mr *rds_ib_alloc_fmr(struct rds_ib_device *rds_ibdev, int npages) return ibmr; out_no_cigar: - if (ibmr) { - if (fmr->fmr) - ib_dealloc_fmr(fmr->fmr); - kfree(ibmr); - } + kfree(ibmr); atomic_dec(&pool->item_count); + return ERR_PTR(err); } -- 2.7.4
