Andrew, On Wed, Feb 15, 2017 at 2:12 PM, Andrew Lunn <and...@lunn.ch> wrote: >> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev) >> macb_get_hwaddr(bp); >> >> /* Power up the PHY if there is a GPIO reset */ >> - phy_node = of_get_next_available_child(np, NULL); >> - if (phy_node) { >> + phy_node = of_parse_phandle(np, "phy-handle", 0); >> + if (!phy_node && of_phy_is_fixed_link(np)) { >> + err = of_phy_register_fixed_link(np); > > Hi Moritz > > I don't see any calls to of_phy_deregister_fixed_link(), either in the > error path, or the remove code.
Whoops, yeah I rebased it from like a year ago. Must've not survived my merge conflict resolution. I'll rework it. Thanks, Moritz