Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

[Andrew Lunn]

> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev)
>               macb_get_hwaddr(bp);
>  
>       /* Power up the PHY if there is a GPIO reset */
> -     phy_node =  of_get_next_available_child(np, NULL);
> -     if (phy_node) {
> +     phy_node = of_parse_phandle(np, "phy-handle", 0);
> +     if (!phy_node && of_phy_is_fixed_link(np)) {
> +             err = of_phy_register_fixed_link(np);

Hi Moritz

I don't see any calls to of_phy_deregister_fixed_link(), either in the
error path, or the remove code.

      Andrew