On Mon, Dec 19, 2016 at 2:14 AM, Dongpo Li <lidon...@hisilicon.com> wrote: > Hi Rob and David, > > On 2016/12/12 22:21, Rob Herring wrote: >> On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li <lidon...@hisilicon.com> wrote: >>> Hi Rob, >>> >>> On 2016/12/10 6:35, Rob Herring wrote: >>>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote:
[...] >>>>> @@ -20,7 +25,7 @@ Required properties: >>>>> >>>>> Example: >>>>> gmac0: ethernet@f9840000 { >>>>> - compatible = "hisilicon,hix5hd2-gmac"; >>>>> + compatible = "hisilicon,hix5hd2-gemac", >>>>> "hisilicon,hisi-gemac-v1"; >>>> >>>> You can't just change compatible strings. >>>> >>> Okay, maybe I should name all the compatible string with the suffix "-gmac" >>> instead of >>> "-gemac". This can keep the compatible strings with the same suffix. Is >>> this okay? >>> Can I just add the generic compatible string without changing the SoCs >>> compatible string? >>> Like following: >>> gmac0: ethernet@f9840000 { >>> - compatible = "hisilicon,hix5hd2-gmac"; >>> + compatible = "hisilicon,hix5hd2-gmac", >>> "hisilicon,hisi-gmac-v1"; >> >> Yes, this is fine. > > As the patch series have been applied to net-next branch, > in which way should I commit this compatible fix? > Should I send a new patch fixing this compatible string error with "Fixes: > xxx"? > Looking forward to your reply! Yes to both. Rob