>-----Original Message-----
>From: David Miller [mailto:[email protected]]
>Sent: Thursday, November 10, 2016 9:18 PM
>To: [email protected]
>Cc: [email protected]; Yotam Gigi <[email protected]>; Ido Schimmel
><[email protected]>; Elad Raz <[email protected]>; Nogah Frankel
><[email protected]>; Or Gerlitz <[email protected]>;
>[email protected]; [email protected]; [email protected];
>[email protected]; [email protected]; [email protected]
>Subject: Re: [patch net-next 1/8] Introduce ife encapsulation module
>
>From: Jiri Pirko <[email protected]>
>Date: Thu, 10 Nov 2016 12:23:01 +0100
>
>> +void *ife_encode(struct sk_buff *skb, u16 metalen)
>
>metalen is u16
>
>> +    metalen = htons(metalen);
>
>htons() returns be16.
>
>> +int ife_tlv_meta_encode(void *skbdata, u16 attrtype, u16 dlen, const void
>*dval)
>> +{
>> +    u32 *tlv = (u32 *) (skbdata);
> ...
>> +    *tlv = htonl(htlv);
>
>Similar situation here.

I will fix those and we will send a v2.

Reply via email to