>-----Original Message----- >From: David Miller [mailto:da...@davemloft.net] >Sent: Thursday, November 10, 2016 9:18 PM >To: j...@resnulli.us >Cc: netdev@vger.kernel.org; Yotam Gigi <yot...@mellanox.com>; Ido Schimmel ><ido...@mellanox.com>; Elad Raz <el...@mellanox.com>; Nogah Frankel ><nog...@mellanox.com>; Or Gerlitz <ogerl...@mellanox.com>; >j...@mojatatu.com; geert+rene...@glider.be; step...@networkplumber.org; >xiyou.wangc...@gmail.com; li...@roeck-us.net; ro...@cumulusnetworks.com >Subject: Re: [patch net-next 1/8] Introduce ife encapsulation module > >From: Jiri Pirko <j...@resnulli.us> >Date: Thu, 10 Nov 2016 12:23:01 +0100 > >> +void *ife_encode(struct sk_buff *skb, u16 metalen) > >metalen is u16 > >> + metalen = htons(metalen); > >htons() returns be16. > >> +int ife_tlv_meta_encode(void *skbdata, u16 attrtype, u16 dlen, const void >*dval) >> +{ >> + u32 *tlv = (u32 *) (skbdata); > ... >> + *tlv = htonl(htlv); > >Similar situation here.
I will fix those and we will send a v2.
