On Wed, May 31, 2006 at 05:09:08PM -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Wed, 31 May 2006 14:20:29 -0700 > > > David, So do we want to fix this issue as proposed by Herbert to replace > > tx_lock with xmit_lock? It seems quite straightforward to do. For this > > change to work, netpoll also needs to be fixed up a bit to check for > > LLTX before getting the xmit_lock. > > Oh yes, netpoll needs changes, thanks for noticing that.
Why does it need to change? The idea is to take the LLTX flag off tg3 after the conversion to xmit_lock. > I think this netpoll wrinkle means we also have to make > sure to set the xmit_lock_owner across the board. You're right. In fact this can deadlock today for those drivers that already make use of xmit_lock without setting the owner. So I suppose something like net_xmit_lock to obtain xmit_lock is called for. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
