On Thu, 2006-06-01 at 10:25 +1000, Herbert Xu wrote: > On Wed, May 31, 2006 at 05:09:08PM -0700, David Miller wrote: > > From: "Michael Chan" <[EMAIL PROTECTED]> > > Date: Wed, 31 May 2006 14:20:29 -0700 > > > > > David, So do we want to fix this issue as proposed by Herbert to replace > > > tx_lock with xmit_lock? It seems quite straightforward to do. For this > > > change to work, netpoll also needs to be fixed up a bit to check for > > > LLTX before getting the xmit_lock. > > > > Oh yes, netpoll needs changes, thanks for noticing that. > > Why does it need to change? The idea is to take the LLTX flag off tg3 > after the conversion to xmit_lock.
Oh, I thought your idea was to keep the LLTX and just replace tx_lock with xmit_lock in tg3. But I suppose we can also clear LLTX, remove the tx_lock in hard_start_xmit and convert the rest to avoid changing netpoll. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
