On 09/05/2016 08:32 PM, Alexei Starovoitov wrote: > On 9/5/16 10:09 AM, Daniel Borkmann wrote: >> On 09/05/2016 04:09 PM, Daniel Mack wrote:
>>> I really don't think it's worth sparing 8 bytes here and then do the >>> binary compat dance after flags are added, for no real gain. >> >> Sure, but there's not much of a dance needed, see for example how map_flags >> were added some time ago. So, iff there's really no foreseeable use-case in >> sight and since we have this flexibility in place already, then I don't >> quite >> follow why it's needed, if there's zero pain to add it later on. I would >> understand it of course, if it cannot be handled later on anymore. > > I agree with Daniel B. Since flags are completely unused right now, > there is no plan to use it for anything in the coming months and > even worse they make annoying hole in the struct, let's not > add them. We can safely do that later. CHECK_ATTR() allows us to > do it easily. It's not like syscall where flags are must have, > since we cannot add it later. Here it's done trivially. Okay then. If you both agree, I won't interfere :) Daniel
