On 08/30/2016 01:00 AM, Daniel Borkmann wrote:
> On 08/26/2016 09:58 PM, Daniel Mack wrote:
>> enum bpf_map_type {
>> @@ -147,6 +149,13 @@ union bpf_attr {
>> __aligned_u64 pathname;
>> __u32 bpf_fd;
>> };
>> +
>> + struct { /* anonymous struct used by BPF_PROG_ATTACH/DETACH commands */
>> + __u32 target_fd; /* container object to attach
>> to */
>> + __u32 attach_bpf_fd; /* eBPF program to attach */
>> + __u32 attach_type; /* BPF_ATTACH_TYPE_* */
>> + __u64 attach_flags;
>
> Could we just do ...
>
> __u32 dst_fd;
> __u32 src_fd;
> __u32 attach_type;
>
> ... and leave flags out, since unused anyway? Also see below.
I'd really like to keep the flags, even if they're unused right now.
This only adds 8 bytes during the syscall operation, so it doesn't harm.
However, we cannot change the userspace API after the fact, and who
knows what this (rather generic) interface will be used for later on.
> #define BPF_PROG_ATTACH_LAST_FIELD attach_type
> #define BPF_PROG_DETACH_LAST_FIELD BPF_PROG_ATTACH_LAST_FIELD
...
>
> Correct way would be to:
>
> if (CHECK_ATTR(BPF_PROG_ATTACH))
> return -EINVAL;
Will add - thanks!
Daniel
