On Wed, 2016-08-24 at 10:50 -0700, John Fastabend wrote: > On 16-08-24 10:26 AM, Eric Dumazet wrote: > > On Wed, 2016-08-24 at 10:13 -0700, John Fastabend wrote: > > > >>> > >> > >> I could fully allocate it in qdisc_alloc() but we don't know if the > >> qdisc needs per cpu data structures until after the init call > > > > Should not we have a flag to advertise the need of per spu stats on > > qdisc ? > > > > This is not clear why ->init() can know this, and not its caller. > > > > sure we could be a static_flags field in the ops structure. What do > you think about doing that?
This is what I was suggesting yes. > > We would still need some flags to be set at init though like the bypass > bit it looks like some qdiscs set that based on user input. >
