On Wed, 2016-08-24 at 10:13 -0700, John Fastabend wrote: > > > > I could fully allocate it in qdisc_alloc() but we don't know if the > qdisc needs per cpu data structures until after the init call
Should not we have a flag to advertise the need of per spu stats on qdisc ? This is not clear why ->init() can know this, and not its caller. > . So it > would sit unused in those cases if done from qdisc_alloc(). It seems > best to me at least to just avoid the allocation in qdisc_alloc() and > do it after init like I did here. > > Perhaps it would be nice to pull these into a function call > post_init_qdisc_alloc() that does all this allocation? > > .John >