> -----Original Message----- > From: Hayes Wang [mailto:hayesw...@realtek.com] > Sent: Friday, June 3, 2016 4:23 AM > To: Limonciello, Mario <mario_limoncie...@dell.com>; > gre...@linuxfoundation.org > Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org; linux- > u...@vger.kernel.org; pali.ro...@gmail.com; anthony.w...@canonical.com > Subject: RE: [PATCH] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > mario_limoncie...@dell.com [mailto:mario_limoncie...@dell.com] > > Sent: Friday, June 03, 2016 12:58 AM > [...] > > > Why generate a random one and not just use the one that the network > > > controler already provides? > > > > That's how the flow works in r8152 already and I'm not overriding it. > > Again, I'll send V2 and you'll see what I did. > > The original flows are > 1. Read MAC address 1 from device. > 2. Check if the MAC address 1 is valid. > 3. Use random MAC address if MAC address 1 is invalid. > > However, your flow would be > 1. Read MAC address 1 from device. > 2. Read MAC address 2 from ACPI. > 3. Check if the MAC address 2 is valid. > 4. Use random MAC address if MAC address 2 is invalid. > > Although MAC address 2 may be invalid, MAC address 1 may be valid. > For this situation, you have to use MAC address 1, not random one. > > Best Regards, > Hayes
Hi Hayes, Once I get information about how to read docking bit, I'll adjust that for v3 to ensure that it falls back to MAC address 1 if #2 is invalid. Thanks
