> -----Original Message----- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, March 31, 2016 12:54 AM > To: Varlese, Marco <marco.varl...@intel.com> > Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko <j...@resnulli.us>; > John Fastabend <john.fastab...@gmail.com>; j...@mojatatu.com; Szczerbik, > PrzemyslawX <przemyslawx.szczer...@intel.com> > Subject: Re: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get_prefix() > error messages > > On Tue, 22 Mar 2016 13:02:02 +0000 > "Varlese, Marco" <marco.varl...@intel.com> wrote: > > > An attempt to add invalid address to interface would print "???" string > > instead of the address family name. > > > > For example: > > $ ip address add 256.10.166.1/24 dev ens8 > > Error: ??? prefix is expected rather than "256.10.166.1/24". > > > > $ ip neighbor add proxy 2001:db8::g dev ens8 > > Error: ??? address is expected rather than "2001:db8::g". > > > > With this patch the output will look like: > > $ ip address add 256.10.166.1/24 dev ens8 > > Error: inet prefix is expected rather than "256.10.166.1/24". > > > > $ ip neighbor add proxy 2001:db8::g dev ens8 > > Error: inet6 address is expected rather than "2001:db8::g". > > > > Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczer...@intel.com> > > Signed-off-by: Marco Varlese <marco.varl...@intel.com> > > --- > > lib/utils.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > If you look at git, I already applied this by manual fix.
Thanks, I didn't see your other email. Thank you for your help!
smime.p7s
Description: S/MIME cryptographic signature
