> -----Original Message----- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Stephen Hemminger > Sent: Sunday, March 27, 2016 6:35 PM > To: Varlese, Marco <marco.varl...@intel.com> > Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko <j...@resnulli.us>; > John Fastabend <john.fastab...@gmail.com>; j...@mojatatu.com; Szczerbik, > PrzemyslawX <przemyslawx.szczer...@intel.com> > Subject: Re: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get_prefix() > error messages > > On Tue, 22 Mar 2016 13:02:02 +0000 > "Varlese, Marco" <marco.varl...@intel.com> wrote: > > > An attempt to add invalid address to interface would print "???" string > > instead of the address family name. > > > > For example: > > $ ip address add 256.10.166.1/24 dev ens8 > > Error: ??? prefix is expected rather than "256.10.166.1/24". > > > > $ ip neighbor add proxy 2001:db8::g dev ens8 > > Error: ??? address is expected rather than "2001:db8::g". > > > > With this patch the output will look like: > > $ ip address add 256.10.166.1/24 dev ens8 > > Error: inet prefix is expected rather than "256.10.166.1/24". > > > > $ ip neighbor add proxy 2001:db8::g dev ens8 > > Error: inet6 address is expected rather than "2001:db8::g". > > > > Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczer...@intel.com> > > Signed-off-by: Marco Varlese <marco.varl...@intel.com> > > --- > > lib/utils.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/utils.c b/lib/utils.c > > index fa35f4d..4820de1 100644 > > --- a/lib/utils.c > > +++ b/lib/utils.c > > @@ -567,7 +567,7 @@ int get_addr(inet_prefix *dst, const char *arg, int > family) > > { > > if (get_addr_1(dst, arg, family)) { > > fprintf(stderr, "Error: %s address is expected rather than \"%s\".\n", > > - family_name(family) ,arg); > > + family_name(dst->family), arg); > > exit(1); > > } > > return 0; > > @@ -581,7 +581,7 @@ int get_prefix(inet_prefix *dst, char *arg, int family) > > } > > if (get_prefix_1(dst, arg, family)) { > > fprintf(stderr, "Error: %s prefix is expected rather than \"%s\".\n", > > - family_name(family) ,arg); > > + family_name(dst->family), arg); > > exit(1); > > } > > return 0; > > Your patch was corrupted by your email client? Yes, you're right; the patch got corrupted by the email client. Sorry about that. Looking into this now.
>
> $ patch -p1
<~/Downloads/iproute2-v1-1-1-lib-utils-fix-get_addr-and-get_prefix-
> error-messages.patch
> patching file lib/utils.c
> patch: **** malformed patch at line 6: {
smime.p7s
Description: S/MIME cryptographic signature
